assert,util: fix deep comparison for sets and maps with mixed types #61388
+26
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
When comparing a Set or a Map and they contain primitives as keys as well as objects, the primitives would always be skipped. That is not correct, since that may only be skipped in case all keys are objects. Fixes: nodejs#61386
BridgeAR
force-pushed
the
BridgeAR/2026-01-15-fix-mixed-sets-and-maps
branch
from
dfd3b80 to
1ee2d1f
Compare
avivkeller
approved these changes
Jan 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61388 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.02%
==========================================
Files 704 704
Lines 208753 208801 +48
Branches 40280 40311 +31
==========================================
+ Hits 184847 184852 +5
- Misses 15907 15922 +15
- Partials 7999 8027 +28
🚀 New features to boost your workflow:
|
BridgeAR
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
cjihrig
approved these changes
Jan 15, 2026
aymen94
approved these changes
Jan 15, 2026
avivkeller
added
the
commit-queue
mertcanaltin
approved these changes
Jan 15, 2026
ljharb
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing a Set or a Map and they contain primitives as keys as well as objects, the primitives would always be skipped. That is not correct, since that may only be skipped in case all keys are objects.
Fixes: #61386